Skip to content

[Doc] Update document #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2022

Conversation

Oliverwqcwrw
Copy link
Contributor

@Oliverwqcwrw Oliverwqcwrw commented May 8, 2022

Follow #2551
Update document for typeAliases

@coveralls
Copy link

coveralls commented May 8, 2022

Coverage Status

Coverage remained the same at 87.311% when pulling 84775fc on Oliverwqcwrw:master-update-configuration-15 into 7b856e8 on mybatis:master.

Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Oliverwqcwrw !

I have modified it a little bit.
Could you copy the change to the localized versions of configuration.xml ?

@Oliverwqcwrw
Copy link
Contributor Author

Hi @harawata ,
I have pulled the changes locally

@Oliverwqcwrw Oliverwqcwrw changed the title Update document [Doc] Update document May 14, 2022
@Oliverwqcwrw Oliverwqcwrw requested a review from harawata May 14, 2022 09:21
@kazuki43zoo kazuki43zoo added the documentation Indicates a changing on documentation(reference or javadoc) label May 15, 2022
@kazuki43zoo kazuki43zoo added this to the 3.5.10 milestone May 15, 2022
@Oliverwqcwrw
Copy link
Contributor Author

Hi @kazuki43zoo ,
I think we can remove the waiting for feedback label. If there is no problem, we can merge it

@kazuki43zoo
Copy link
Member

kazuki43zoo commented May 15, 2022

@Oliverwqcwrw

Could you copy the change to the localized versions of configuration.xml ?

Cannot apply above comment?

@Oliverwqcwrw
Copy link
Contributor Author

@Oliverwqcwrw

Could you copy the change to the localized versions of configuration.xml ?

Cannot apply above comment?

Sorry, I thought I had committed the code, But it's actually still local

@Oliverwqcwrw
Copy link
Contributor Author

Hi @kazuki43zoo,
I have copied the change to the localized version and Pls review it again

@Oliverwqcwrw
Copy link
Contributor Author

Hi @kazuki43zoo ,

I have a question,I have applied the changes, why is this state still changes requested
image

@awxiaoxian2020
Copy link
Contributor

Changes requested

I can't reproduce the situation. But I have a wild guess:
There are "approve" button or Do you check the "three points" button to next step?

@harawata harawata merged commit a599fdc into mybatis:master May 15, 2022
@harawata harawata self-assigned this May 15, 2022
@harawata
Copy link
Member

Thank you all!

@Oliverwqcwrw
Copy link
Contributor Author

Sorry,I confused the meaning of localized with local, so I didn't fully understand your request change, which was very embarrassing

@harawata
Copy link
Member

@Oliverwqcwrw ,
No big deal. Don't worry about it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates a changing on documentation(reference or javadoc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants