Cache generic param names

[kang-hl]

No description provided.

[coveralls]

coverage: 87.175% (+0.005%) from 87.17%
when pulling a854fa8 on kang-hl:add-cache
into e836410 on mybatis:master.

[hazendaz]

@harawata Any concerns here? I don't see any real difference on processing of a build along with tests from any outstanding builds. This is probably very micro here at caching so not fully seeing the value. Plus seems odd that we prep for full 255 when that number is probably more often than not too high.

[harawata]

Yeah. It is rare to see a statement with 5+ parameters.

It might be possible to cache only the first five or ten names and create the others on the fly, but it requires an extra check, so ... I'm not sure.

genericParamName = i < 10 ? CACHED[i] : PREFIX + (i + 1);

[kang-hl]

Yeah. It is rare to see a statement with 5+ parameters.

It might be possible to cache only the first five or ten names and create the others on the fly, but it requires an extra check, so ... I'm not sure.

genericParamName = i < 10 ? CACHED[i] : PREFIX + (i + 1);

Adding an environment variable to change this value may be better.

[kang-hl]

Yeah. It is rare to see a statement with 5+ parameters.

It might be possible to cache only the first five or ten names and create the others on the fly, but it requires an extra check, so ... I'm not sure.

genericParamName = i < 10 ? CACHED[i] : PREFIX + (i + 1);

Adding an environment variable to change this value may be better.

[harawata]

@kang-hl ,

I prefer not to add a new config option for this.
How many parameters does your statement actually have?

[kang-hl]

@kang-hl ,

I prefer not to add a new config option for this. How many parameters does your statement actually have?

Only a few at most, but not everyone is like this. Can only add one environment variable or an extra check or keep it as is, which one do you prefer?

[harawata]

Let's just cache the first ten names.
It covers more than 95%, I believe.

And we can change it anytime if we need to.

[kang-hl]

Let's just cache the first ten names. It covers more than 95%, I believe.

And we can change it anytime if we need to.

Modified.

[epochcoder]

for i > 10 this will return a ArrayIndexOutOfBoundsException,

[coveralls]

coverage: 87.175% (+0.005%) from 87.17%
when pulling 859a254 on kang-hl:add-cache
into e836410 on mybatis:master.

[harawata]

Thank you for the PR, @kang-hl !
And thank you for the review, @epochcoder !