Skip to content

Display online english guide #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Display online english guide #3194

merged 4 commits into from
Jul 5, 2024

Conversation

ngocnhan-tran1996
Copy link
Contributor

As report in

#3186

AFAIK, a newest maven version cause blank site.

Markdown conflict with Velocity on ## syntax:
Since ## denotes a single line comment in Velocity, Markdown headers using this syntax are suppressed from generated content.
You can use unparsed content syntax #[[##]]# or escape tool like ${esc.h}${esc.h}.

More detail maven-site-plugin

But I found the another way.
If markdown file does not contains # Title, only add tag h1

@hazendaz hazendaz self-assigned this Jul 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 87.175%. remained the same
when pulling 2757fff on ngocnhan-tran1996:issues-3186
into 2e62ab5 on mybatis:master.

@hazendaz hazendaz merged commit d6b8e4e into mybatis:master Jul 5, 2024
19 checks passed
@hazendaz
Copy link
Member

hazendaz commented Jul 5, 2024

Thanks @ngocnhan-tran1996. I did not confirm but see no issue with the add. I'll check later as it seems we have some other issue with site not releasing when gh-pages is updated. I'll try to check this weekend.

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the issues-3186 branch July 16, 2024 14:59
@awxiaoxian2020
Copy link
Contributor

I think this PR need to apply to all mybatis projects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants