Added PropertyCopier test case #3228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added PropertyCopier test case |
…' into ref_add_propertyCopier_test_case # Conflicts: # src/test/java/org/apache/ibatis/reflection/property/PropertyCopierTest.java # src/test/java/org/apache/ibatis/reflection/property/SourceBeanTestClass.java
|
@tianchangxin Can you rename the class file used for the test? I'd prefer 'Test' and 'Class' not be in the name. Not sure on a good naming otherwise but best not to repeat class or have test in it generally. |
Thank you for your reply. I will make some modifications |
|
@hazendaz The naming has been modified, please help with the code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I read the PropertyCopier class in the reflection package, I wanted to test, but there was no test class, so I added the corresponding test class