Skip to content

remove the local variable and return the result directly #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

remove the local variable and return the result directly #87

merged 2 commits into from
May 22, 2019

Conversation

xuejiangtao
Copy link
Contributor

@xuejiangtao xuejiangtao commented May 21, 2019 •
edited
Loading

@jeffgbutler ,hello, i found the Code Smell just the same as #86 .
Return the personMapper.count(selectStatement); directly to improve the Code Quality.
See details in #86

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling debd575 on xuejiangtao:master into d748511 on mybatis:master.

@jeffgbutler jeffgbutler merged commit b8d0765 into mybatis:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuejiangtao @coveralls @jeffgbutler