Add unit of measure and default to ConnectionTimeout #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The summary is what is shown by consumers when using autocomplete. This change allows consumers to easily see the unit of measure (seconds) as well as the default value when using autocomplete/code completion. I'm proposing this change because it wasn't clear to me if the timeout was in seconds or milliseconds. Also, i had no idea what the default is/was until I added a breakpoint in my code that was consuming this. Signed-off-by: Amalfitano, Joseph <[email protected]> ~ ~
JosephAmalfitanoSSA
force-pushed
the
patch-1
branch
from
9f67db7 to
016daf8
Compare
|
This picture shows the current state of the summary/tooltip. My proposed change will make it clear that the unit of measure is in seconds and the default timeout is 15 seconds.
|
|
Thanks for the contribution! FYI, several of these properties are initialised from the connection string (or its defaults), and even though they don't have XML documentation, they are all described here: https://mysqlconnector.net/connection-options/ |
|
Added in 0.60.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The summary is what is shown by consumers when using autocomplete. This change allows consumers to easily see the unit of measure (seconds) as well as the default value when using autocomplete/code completion.
I'm proposing this change because it wasn't clear to me if the timeout was in seconds or milliseconds. Also, i had no idea what the default is/was until I added a breakpoint in my code that was consuming this.