Bug#36746818 Sorting (PARTITION BY, ORDER BY) no longer stable for window functions: MacOS

Also fixes Bug#36795676 Test main.window_functions failing
Also fixes Bug#36795679 Test main.window_jsonaggs failing

A query with a window function in window_functions.test was
non-deterministic.  The window specification had a PARTITION clause,
but no ORDER BY clause, so we saw different results on Linux than on
MacOS. Ordering in MySQL doesn't necessarily do a stable sort, so we
cannot rely on a specific row ordering inside a window partition
unless we have a sufficient ORDER BY clause in the window
spcification.

Solution: remove non-deterministic query.
Change-Id: I72f5a213119f51429e7eac58fd8c6aacef71a6d8

Author: Dag Wanvik

mysql-test/r/window_functions.result

@@ -3716,32 +3716,6 @@ t	FIRST_VALUE(t) OVER w
 20:30:00	22:30:00
 21:30:00	NULL
 22:30:00	NULL
-SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p );
-p	t	FIRST_VALUE(t) OVER w
-1	00:30:00	12:30:00
-1	00:31:00	12:30:00
-1	01:30:00	12:30:00
-1	04:30:00	12:30:00
-1	06:30:00	12:30:00
-1	12:30:00	12:30:00
-1	13:30:00	12:30:00
-1	15:30:00	12:30:00
-1	18:30:00	12:30:00
-1	20:30:00	12:30:00
-1	21:30:00	12:30:00
-1	22:30:00	12:30:00
-2	00:30:00	12:30:00
-2	00:31:00	12:30:00
-2	01:30:00	12:30:00
-2	04:30:00	12:30:00
-2	06:30:00	12:30:00
-2	12:30:00	12:30:00
-2	13:30:00	12:30:00
-2	15:30:00	12:30:00
-2	18:30:00	12:30:00
-2	20:30:00	12:30:00
-2	21:30:00	12:30:00
-2	22:30:00	12:30:00
 SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p ORDER BY t);
 p	t	FIRST_VALUE(t) OVER w
 1	00:30:00	00:30:00

mysql-test/r/window_jsonaggs.result

@@ -159,23 +159,27 @@ zxczcx	39	[null, "24324", "poipo", "efghi", "fsfd", "ffhfg", "efghi", "efghi", "
 uwrteu	43	[null, "24324", "poipo", "efghi", "fsfd", "ffhfg", "efghi", "efghi", "dfgdf", "dkfhk", null, "sdfsd", "wqweq", "zxczcx", "uwrteu"]	[0, 1, 6, 10, 10, 13, 20, 21, 23, 28, 29, 30, 32, 39, 43]
 NULL	100	[null, "24324", "poipo", "efghi", "fsfd", "ffhfg", "efghi", "efghi", "dfgdf", "dkfhk", null, "sdfsd", "wqweq", "zxczcx", "uwrteu", null]	[0, 1, 6, 10, 10, 13, 20, 21, 23, 28, 29, 30, 32, 39, 43, 100]
 # With ROLLUP
+# Originally, this query had just (ORDER BY f) - and all f
+# values are NULL - so it was non-deterministic and showed
+# differences across platforms due to unstable sorting. The new
+# frame spec captures the same data but deterministically
 SELECT i, f, JSON_ARRAYAGG(i) OVER w jarray_i, JSON_ARRAYAGG(f)
 OVER w jarray_f FROM t1 GROUP BY i,f WITH ROLLUP HAVING GROUPING(f)=1
-WINDOW w AS (ORDER BY f);
+WINDOW w AS (ORDER BY f, i ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING);
 i	f	jarray_i	jarray_f
-1	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-10	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-11	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-13	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-15	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-2	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-3	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-4	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-5	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-8	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-9	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-NULL	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
-NULL	NULL	[null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+NULL	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+NULL	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+1	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+2	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+3	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+4	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+5	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+8	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+9	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+10	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+11	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+13	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
+15	NULL	[null, null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15]	[null, null, null, null, null, null, null, null, null, null, null, null, null]
 # With other window functions
 SELECT i, f, RANK() OVER w rank1, NTH_VALUE(i,3)
 OVER w nth, LEAD(f, 2) OVER w lead1, LAG(f,2) OVER w lag1, JSON_ARRAYAGG(i)

mysql-test/t/window_functions.test

@@ -1242,8 +1242,6 @@ SELECT t, FIRST_VALUE(t) OVER w FROM t_time WINDOW w AS (ORDER BY t RANGE BETWEE
 SELECT t, FIRST_VALUE(t) OVER w FROM t_time WINDOW w AS (ORDER BY t ROWS  BETWEEN 2 FOLLOWING AND 3 FOLLOWING);
 SELECT t, FIRST_VALUE(t) OVER w FROM t_time WINDOW w AS (ORDER BY t RANGE BETWEEN INTERVAL 2 HOUR FOLLOWING AND INTERVAL 3 HOUR FOLLOWING);
 
---sorted_result
-SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p );
 SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p ORDER BY t);
 SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p ORDER BY t DESC);
 SELECT p, t, FIRST_VALUE(t) OVER w FROM t_time2 WINDOW w AS (PARTITION by p ORDER BY t ROWS  2 PRECEDING);

mysql-test/t/window_jsonaggs.test

@@ -51,12 +51,13 @@ SELECT s, j, JSON_ARRAYAGG(s) OVER w jarray_s, JSON_ARRAYAGG(j)
 
 --echo # With ROLLUP
 
-# The order here is undefined and implementation-dependent.
---sorted_result
---replace_regex /9, 10, 8, 11, 5, 4, 3, 13, 2, 1, 15, null, null/null, 1, 2, 3, 4, 5, 8, 9, 10, 11, 13, 15, null/
+--echo # Originally, this query had just (ORDER BY f) - and all f
+--echo # values are NULL - so it was non-deterministic and showed
+--echo # differences across platforms due to unstable sorting. The new
+--echo # frame spec captures the same data but deterministically
 SELECT i, f, JSON_ARRAYAGG(i) OVER w jarray_i, JSON_ARRAYAGG(f)
   OVER w jarray_f FROM t1 GROUP BY i,f WITH ROLLUP HAVING GROUPING(f)=1
-  WINDOW w AS (ORDER BY f);
+  WINDOW w AS (ORDER BY f, i ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING);
 
 --echo # With other window functions