Bug #76852 - Segmentation fault while starting MySQL with binary log in disk full Linux #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
I have already did this and it is approved.MySQL bug system user/email -> [email protected], 16:48, "mysql-oca-bot" [email protected]:Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread. Shahriyar Rzayev : Linux/MySQL Administrator(OCP,RHCSA)Personal blog : http://mysql.azBug Hunter as nature : MySQL BUG Database |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary:
This diff fixes two bugs that returned missing rows with prefix bloom
filter.
1. Range scan with equal predicates (i.e. WHERE id1=1 AND id2>=1). In
this case, equal condition length should be (index_id + id1) and prefix
bloom filter should be skipped if the length is shorter than prefix
bloom length. Without this diff, equal condition length was (index_id +
id1 + id2), which was incorrect.
2. IN clause with different condition length (i.e. WHERE name IN
('AAAAAAA', 'A'). In this case, ha_rocksdb::setup_index_scan() is called
multiple times, and equal condition length is different. So whether to
use prefix bloom filter should be decided one by one.
@update-submodule: rocksdb
Test Plan: bloomfilter2
Reviewers: jkedgar, maykov, hermanlee4, spetrunia
Reviewed By: spetrunia
Differential Revision: https://reviews.facebook.net/D46851
Differential Revision: https://reviews.facebook.net/D47085
Differential Revision: https://reviews.facebook.net/D47169
Differential Revision: https://reviews.facebook.net/D50181
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary:
MyRocks doesn't support next-key locking so binlog_format!=ROW
may cause data inconsistency. On 5.6 slaves, binlog_format!=ROW is fine
because no concurrent access to the same table is guaranteed.
This diff changes as below.
- Rejecting updates (locking reads, including SELECT FOR UPDATE) on master
- No behavior changes on slave
- No behavior changes if binlog was disabled on the session
- Added a new session variable rocksdb_unsafe_for_binlog to optionally
allow writing with statement based binary logging
Test Plan: mtr, new test case rpl_statement
Reviewers: spetrunia, hermanlee4, jkedgar, santoshb
Reviewed By: santoshb
Subscribers: webscalesql-eng
Differential Revision: https://reviews.facebook.net/D51231
Differential Revision: https://reviews.facebook.net/D51489
Differential Revision: https://reviews.facebook.net/D51555
Differential Revision: https://reviews.facebook.net/D51597
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary:
This diff fixes two bugs that returned missing rows with prefix bloom
filter.
1. Range scan with equal predicates (i.e. WHERE id1=1 AND id2>=1). In
this case, equal condition length should be (index_id + id1) and prefix
bloom filter should be skipped if the length is shorter than prefix
bloom length. Without this diff, equal condition length was (index_id +
id1 + id2), which was incorrect.
2. IN clause with different condition length (i.e. WHERE name IN
('AAAAAAA', 'A'). In this case, ha_rocksdb::setup_index_scan() is called
multiple times, and equal condition length is different. So whether to
use prefix bloom filter should be decided one by one.
@update-submodule: rocksdb
Test Plan: bloomfilter2
Reviewers: jkedgar, maykov, hermanlee4, spetrunia
Reviewed By: spetrunia
Differential Revision: https://reviews.facebook.net/D46851
Differential Revision: https://reviews.facebook.net/D47085
Differential Revision: https://reviews.facebook.net/D47169
Differential Revision: https://reviews.facebook.net/D50181
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary:
MyRocks doesn't support next-key locking so binlog_format!=ROW
may cause data inconsistency. On 5.6 slaves, binlog_format!=ROW is fine
because no concurrent access to the same table is guaranteed.
This diff changes as below.
- Rejecting updates (locking reads, including SELECT FOR UPDATE) on master
- No behavior changes on slave
- No behavior changes if binlog was disabled on the session
- Added a new session variable rocksdb_unsafe_for_binlog to optionally
allow writing with statement based binary logging
Test Plan: mtr, new test case rpl_statement
Reviewers: spetrunia, hermanlee4, jkedgar, santoshb
Reviewed By: santoshb
Subscribers: webscalesql-eng
Differential Revision: https://reviews.facebook.net/D51231
Differential Revision: https://reviews.facebook.net/D51489
Differential Revision: https://reviews.facebook.net/D51555
Differential Revision: https://reviews.facebook.net/D51597
dbussink
pushed a commit
to planetscale/mysql-server
that referenced
this pull request
Mar 6, 2024
…grams without writing to system tables (mysql#111) * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>
dbussink
pushed a commit
to planetscale/mysql-server
that referenced
this pull request
May 21, 2024
…grams without writing to system tables (mysql#111) * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>
dbussink
pushed a commit
to planetscale/mysql-server
that referenced
this pull request
May 21, 2024
…grams without writing to system tables (mysql#111) * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> * New `ANALYZE TABLE ... QUERY HISTOGRAM` syntax to fetch histograms without writing to system tables (mysql#109) * ANALYZE TABLE ... QUERY HISTOGRAM Signed-off-by: Shlomi Noach <[email protected]> * validate 'WITH [n] BUCKETS' syntax works Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to BUG report,
my_printf_warningfunction is calling*sql_print_warning_hookwhich is NULL/uninitialized at that point of crash.The 2 possible solution is initialize
sql_print_warning_hook= sql_print_warningat the top ofinit_server_components()or to add a check forsql_print_warning_hookinsidemy_error.c/my_printf_warning(). The best to have both of them.