Check algorithm=innodb on crc32 checksum mismatch before crc32(big endian) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a page has had its checksum fail and the algorithm = CRC32, its most likely because we've updated from 5.6 where the default was algorithm=innodb. We should test that algorithm innodb on the page passes before testing the crc32 in big endian way ( page_zip_calc_checksum(..., true)) as its more likely to be true.
grooverdan
changed the title
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
vmg
pushed a commit
to planetscale/mysql-server
that referenced
this pull request
Nov 21, 2023
…rtion Fix broken assertion for rows read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page has had its checksum fail and the algorithm = CRC32,
its most likely because we've updated from 5.6 where the default
was algorithm=innodb. We should test that algorithm innodb on the
page passes before testing the crc32 in big endian way (
page_zip_calc_checksum(..., true)) as its more likely to be true.