fix for innodb_numa_interleave missing #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so this is a copy of the patch in http://bugs.mysql.com/bug.php?id=80288 |
|
Yes, that is correct. I verified the same fix is needed for the 5.6 branch and was hoping to get it fixed here as well. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi Igroenewold, Thanks |
|
@mysql-admin, would it work if I or my colleague who wrote the patch confirmed this as an OCA submission? |
|
@laurynas-biveinis your colleague (that wrote the patch) is currently not part of your 'group' OCA. He needs to be added there so we can associate the OCA with his bug system user. Then, he can submit it via a pull request similar to this one. Thanks |
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
Dec 6, 2023
The "fast" prng algorithm was really poorly distributed and only used a system counter as input. This was causing failures somehow specifically on Ubuntu Jammy, but it's a broken fast prng by design. Instead, this PR uses shishua (https://github.com/espadrine/shishua) as a PRNG. We have replaced both the slow and fast PRNGs with this new implementation because it offers better randomness for both cases and it's competitive in micro-benchmarks. Before/baseline: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 16593 iterations 60199 ns/iter 15.84 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (1004 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 50909 iterations 19610 ns/iter 48.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1000 ms) After/xishua: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 42351 iterations 23475 ns/iter 40.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (996 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 41897 iterations 23845 ns/iter 40.00 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1001 ms) Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
Dec 7, 2023
The "fast" prng algorithm was really poorly distributed and only used a system counter as input. This was causing failures somehow specifically on Ubuntu Jammy, but it's a broken fast prng by design. Instead, this PR uses shishua (https://github.com/espadrine/shishua) as a PRNG. We have replaced both the slow and fast PRNGs with this new implementation because it offers better randomness for both cases and it's competitive in micro-benchmarks. Before/baseline: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 16593 iterations 60199 ns/iter 15.84 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (1004 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 50909 iterations 19610 ns/iter 48.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1000 ms) After/xishua: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 42351 iterations 23475 ns/iter 40.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (996 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 41897 iterations 23845 ns/iter 40.00 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1001 ms) Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]>
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
May 21, 2024
The "fast" prng algorithm was really poorly distributed and only used a system counter as input. This was causing failures somehow specifically on Ubuntu Jammy, but it's a broken fast prng by design. Instead, this PR uses shishua (https://github.com/espadrine/shishua) as a PRNG. We have replaced both the slow and fast PRNGs with this new implementation because it offers better randomness for both cases and it's competitive in micro-benchmarks. Before/baseline: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 16593 iterations 60199 ns/iter 15.84 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (1004 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 50909 iterations 19610 ns/iter 48.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1000 ms) After/xishua: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 42351 iterations 23475 ns/iter 40.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (996 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 41897 iterations 23845 ns/iter 40.00 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1001 ms) Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
May 21, 2024
The "fast" prng algorithm was really poorly distributed and only used a system counter as input. This was causing failures somehow specifically on Ubuntu Jammy, but it's a broken fast prng by design. Instead, this PR uses shishua (https://github.com/espadrine/shishua) as a PRNG. We have replaced both the slow and fast PRNGs with this new implementation because it offers better randomness for both cases and it's competitive in micro-benchmarks. Before/baseline: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 16593 iterations 60199 ns/iter 15.84 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (1004 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 50909 iterations 19610 ns/iter 48.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1000 ms) After/xishua: [ RUN ] Microbenchmarks.BM_RND_GEN BM_RND_GEN 42351 iterations 23475 ns/iter 40.63 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN (996 ms) [ RUN ] Microbenchmarks.BM_RND_GEN_FAST BM_RND_GEN_FAST 41897 iterations 23845 ns/iter 40.00 MB/sec [ OK ] Microbenchmarks.BM_RND_GEN_FAST (1001 ms) Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest MySQL 5.6 misses the innodb_numa_interleave server variable.
https://bugs.mysql.com/bug.php?id=78953