Skip to content

Update READMEs #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 145 commits into from
Feb 3, 2021
Merged

Update READMEs #230

merged 145 commits into from
Feb 3, 2021

Conversation

FestplattenSchnitzel
Copy link
Contributor

@FestplattenSchnitzel FestplattenSchnitzel commented Jan 27, 2021 •
edited
Loading

It seems all the READMEs are quite outdated. I've updated them.

Things to do:

  • Main README: Add links to Material Design Specs
  • Package READMEs:
    • Table of contents
    • Changelog entries
    • FAQ entries (referring to main README)
    • API Attributes, Events, Methods (maybe another MR)
    • Unified NativeScript casing
    • h1 titles
    • valid CSS comments
    • update npm shields
  • some misc fixes

@FestplattenSchnitzel
Copy link
Contributor Author

BTW: Can someone please explain to me what's the difference between Bottom Navigation and Bottom Navigation Bar?

@FestplattenSchnitzel FestplattenSchnitzel changed the title WIP:Update README, sorting, readme, npm WIP:Update READMEs Jan 27, 2021
@farfromrefug
Copy link
Member

farfromrefug commented Jan 27, 2021 •
edited
Loading

@FestplattenSchnitzel bottom navigation bar is a new component to draw a bottom navigation bar in matérial design.
bottom navigation is a simple extract of the component from N. the idea is to be able at one point to remove it from N. as it uses material libs it has its place here.
in the future things could get refactored. but for now it must remain that way for easy transition

@farfromrefug
Copy link
Member

@FestplattenSchnitzel already looks really cool !

@FestplattenSchnitzel FestplattenSchnitzel marked this pull request as ready for review February 3, 2021 15:14
@FestplattenSchnitzel FestplattenSchnitzel changed the title WIP:Update READMEs Update READMEs Feb 3, 2021
@FestplattenSchnitzel
Copy link
Contributor Author

@farfromrefug this is now ready from my side.

@farfromrefug
Copy link
Member

@FestplattenSchnitzel awesome! Thanks a lot!

@farfromrefug farfromrefug merged commit c35e0fa into nativescript-community:master Feb 3, 2021
@FestplattenSchnitzel FestplattenSchnitzel mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FestplattenSchnitzel @farfromrefug