Skip to content

fix (bottomsheet ios) correct resizing like on android version #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2021
Merged

fix (bottomsheet ios) correct resizing like on android version #277

merged 4 commits into from
Apr 22, 2021

Conversation

alexander-mai
Copy link
Contributor

bottomsheet implementation

  • made ios bottomsheet always full width like the android version
  • fixed resizing of bottomsheet on rotating the screen
    • previously the size was only reduced, but not enlarged when rotating from portrait to landscape
  • fixed safe area sizes

demo application

  • fixed imports on demo app
  • added additional demo variants for bottomsheet to demo app for showing the correct handling of safe areas

Alexander Mai and others added 4 commits April 14, 2021 10:27
* made ios bottomsheet always full width like the android version
* fixed resizing of bottomsheet on rotating the screen
  * previously the size was only reduced, but not enlarged when rotating from portrait to landscape
* fixed safe area sizes

* fixed imports on demo app
* added additional demo variants for bottomsheet to demo app for showing the correct handling of safe areas
@farfromrefug farfromrefug merged commit 02e357b into nativescript-community:master Apr 22, 2021
@farfromrefug
Copy link
Member

@alexander-mai thanks. I did have to do it diffently cause your changes broke a few things but now it is better.
However it is not perfect and at the end safearea need to be fixed on N side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants