feat(react): Tabs, TabStrip, TabStripItem, BottomNavigation, and TabC… #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirakaba
force-pushed
the
feat/react-navigators
branch
from
c74a67a to
648b9cd
Compare
shirakaba
force-pushed
the
feat/react-navigators
branch
from
936b5a7 to
ad1d16a
Compare
…ting items) and correct log messages
|
@farfromrefug I'm happy for this to be reviewed now. I've confirmed that it works by adding a demo app.
(Excuse the horrific colour palette :D) |
|
@shirakaba awesome seems good to me! |
|
Thanks for the lightning review 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontentItem for NativeScript 8
I guess I'd better set up a React sample app rather than blindly just assuming that this copy-paste from RNS (based on NativeScript 7, when they were core components) will work. So I'll call this PR a draft for now.