feat(BottomSheet): add default collapsed sheet height for android #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

farfromrefug merged 2 commits into nativescript-community:master from vallemar:master

Sep 20, 2021

Contributor

vallemar commented Sep 19, 2021

Related to #306


          feat: BottomSheet add default collapsed sheet height for android

0b4e85c

Member

farfromrefug commented Sep 20, 2021

@vallemar so the iOS counterpart is not working? Event with the setPee... method? Could you stil add the code to that PR so that i can look at it ?


          add ios platform

adea36b

Contributor Author

vallemar commented Sep 20, 2021 •

edited

Loading

@farfromrefug I have added the code for ios, but it does nothing :(
I think this is the line that is establishing the height: https://github.com/vallemar/ui-material-components/blob/master/src/bottomsheet/bottomsheet.ios.ts#L168

farfromrefug merged commit 4ef8c84 into nativescript-community:master

Member

farfromrefug commented Sep 20, 2021

@vallemar i released it for iOS/Android ! thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet