Skip to content

fix(tabs): delay layout until tabs finish transitioning #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edusperoni
Copy link
Contributor

Starting with iOS 15 if you make any layout changes in the tabs content while it's animating, the animation will hang and the tabs will be left in an inconsistent state.

This PR makes sure requestLayout is never called in this state

@farfromrefug
Copy link
Member

@edusperoni thanks ! i wished we had my changes on requestLayout in the core. This would be so much easier.
Thanks again

@farfromrefug farfromrefug merged commit ac1925b into nativescript-community:master Feb 7, 2022
@msl2000
Copy link

msl2000 commented Apr 28, 2022

There still seems to be a problem with this. When you manually change the selected index programatically, it still hangs when the layout is making changes. The problem has been fixed when clicking on the Tabstrip items directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants