Skip to content

fix(tabs): use relative fragment manager #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

edusperoni
Copy link
Contributor

@edusperoni edusperoni commented Feb 8, 2022

@farfromrefug we were unsure this fix was needed, but apparently it is, as tabs break on modal pages

@farfromrefug
Copy link
Member

@edusperoni what bugs me is that i think it was changed to Root before because it was creating an issue :s
i am not sure what to do. Maybe we should at least create more sample in the demo app (not sure which one) to ensure we can test all cases when we make changes like this? (not asking to do it for this PR)

@edusperoni
Copy link
Contributor Author

I was talking to @NathanWalker about it some time ago and I believe we need some kind of integration testing with NativeScript core and the material components overall, considering tabs and botom nav are part of the template projects. Still wondering how exactly we should do it, but I definitely see your point.

That fix on BottomNavigation actually fixed a lot of stuff on our many prod projects, so maybe something changed since your last try?

@edusperoni edusperoni merged commit b9dc946 into master Feb 8, 2022
@edusperoni edusperoni deleted the fix/tabs-fragmentmanager branch February 8, 2022 16:51
@farfromrefug
Copy link
Member

@edusperoni yes i dont know i would say that change dates from before the migration to this repo but i am 1000% sure.
we could get some detox tests set-up. Though i am really not the best with tests :P

  • [ ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants