-
-
Notifications
You must be signed in to change notification settings - Fork 80
feat(BottomSheet): (Android only) allows to interact with the screen behind the sheet #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vallemar very nice. Not sure you can do that on iOS though :s Do you want me to merge this now or do you want to add iOS if possible first? |
@farfromrefug I wouldn't know what to tell you. It is what you say, I have been trying to make it work on iOS but I have not succeeded. Do you think it would be good to merge it and if later it is achieved by us or any other, will you add it? I think I would merge it because the operation is quite useful |
@vallemar agree, merged! Will make a release soon |
@farfromrefug Thank you! I've been seeing that on iOS you can also override the event of the view and pass it to the top view, tonight I'll try this, hopefully we could ignore the google plugin and do it via the generated views! Then I will leave a summary of what I have achieved to have it somewhere! |
I've tried using |
@vallemar must be because it uses a presented view controller. |
@vallemar Just built with your PR. What is |
Hi @farfromrefug, |
@vallemar it is not a error at runtime. It is a tsc error which prevented the build of the plugin. I dont understand your point about |
@farfromrefug |
@vallemar ok thanks will look in material android code for it. thanks |
Copying this info written by @ammarahm-ed in Discord, so it doesn't get lost.
Does that mean for iOS the implementation would have to be fundamentally different for this to work? |
@MrSnoozles I have tried this in ios in all possible ways but without success, have you been able to do it? |
When you have a sheet open in the middle of the screen you cannot interact with the screen behind it, this PR adds that you can interact.
For now it only supports Android, I want to make it work for iOS too
old behavior:
https://user-images.githubusercontent.com/15719383/184112618-12c07bbb-1b10-418d-809c-f19a5f81a4bd.mp4
new behavior:
https://user-images.githubusercontent.com/15719383/184112497-45eca734-d8c3-4fa8-849f-a3bd73fce1cc.mp4