Skip to content

fix(bottomnavigationbar): select tab native view #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lekhmanrus
Copy link

Sometimes it was throwing ".getMenu() of undefined" error.

@farfromrefug
Copy link
Member

@lekhmanrus i am not sure how it would solve it. actually nativeView is a. simple getter on nativeViewProtected
I think the right fix would be this.nativeViewProtected?.getMenu();

@lekhmanrus
Copy link
Author

@farfromrefug, maybe it was a coincidence, but it looks like when I used nativeViewProtected I didn't see that error anymore. Anyway, I think you are right and just committed the fixes.

@lekhmanrus lekhmanrus force-pushed the bottomnavigationbar-select-tab-native-view branch from 0e17978 to 7a0debe Compare September 20, 2022 14:47
@farfromrefug farfromrefug merged commit e3f787c into nativescript-community:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants