Skip to content

fix(android): active tab not displaying after nav back to page #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dgmachado
Copy link

Android Issue: Active Tab item not displaying after nav back

Reproduce steps:

  1. On app with multiple (overflown) tab items, Switch to the last tab item
  2. Navigate to a new page
  3. Nav back to the page with Tabs
  4. Notice the active last tab item is not showing. The tab strip is showing the most left / initial tab items instead.

Expect: the tab strip to show the last displayed position before navigating to the new page.

Video:
https://user-images.githubusercontent.com/5738416/224697030-f659224c-cfc5-4531-8dd6-f10b84a0c1de.mov

@farfromrefug
Copy link
Member

@dgmachado seems good could you just add a comment where you do the setTimeout so we understand why the code is there?

@farfromrefug farfromrefug merged commit 9f985f2 into nativescript-community:master Mar 14, 2023
@farfromrefug
Copy link
Member

@dgmachado awesome thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants