Keep bookmark returned after auto-commit tx #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-commit transactions return bookmarks in Bolt V3. They were previously unused. This commit makes driver extract such bookmarks and expose them via `Session#lastBookmark()`. It then possible for explicit and auto-commit transactions within the same session to be chained with bookmarks.
lutovich
force-pushed
the
1.7-bookmark-after-auto-commit-tx
branch
from
ee80e58 to
86cf222
Compare
|
The concept of BookmarkHolder is really good. Wondering if it also makes sense to make Tx to get and set bookmark via BookmarkHolder too. |
Pass it directly to the session, when the transaction is committed. This simplifies `ExplicitTransaction` a bit by removing all bookmark handling from it.
|
@zhenlineo I removed all the bookmark handling from transaction :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-commit transactions return bookmarks in Bolt V3. They were previously unused. This PR makes driver extract such bookmarks and expose them via
Session#lastBookmark(). It then possible for explicit and auto-commit transactions within the same session to be chained with bookmarks.