Skip to content

Use composite cumulator for message decoding #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Use composite cumulator for message decoding #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions driver/src/main/java/org/neo4j/driver/internal/async/inbound/MessageDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,15 @@

public class MessageDecoder extends ByteToMessageDecoder
{
private static final Cumulator DEFAULT_CUMULATOR = determineDefaultCumulator();

private boolean readMessageBoundary;

public MessageDecoder()
{
setCumulator( DEFAULT_CUMULATOR );
}

@Override
public void channelRead( ChannelHandlerContext ctx, Object msg ) throws Exception
{
Expand Down Expand Up @@ -60,4 +67,14 @@ protected void decode( ChannelHandlerContext ctx, ByteBuf in, List<Object> out )
readMessageBoundary = false;
}
}

private static Cumulator determineDefaultCumulator()
{
String value = System.getProperty( "messageDecoderCumulator", "" );
if ( "merge".equals( value ) )
{
return MERGE_CUMULATOR;
}
return COMPOSITE_CUMULATOR;
}
}