Suppress pool was closed errors
#597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a routing driver, it is possible that a thread will try to acquire a connection from a pool which might have been closed by another thread. This happens when thread A obtains a server S to establish a connection. While thread B triggers updating routing table and removes server S from the routing table and connection pool. Then when thread A process to acquire a connection with server S, then we will end up with this pool was closed error. This race condition cannot be avoided due to the nature of multi-threading. However when it happens, we can catch the error and treat it as a normal IO Error.
All failures that will be retried or are temporary in the middle of updating routing table are now all marked as INFO.
ali-ince
reviewed
May 7, 2019
driver/src/main/java/org/neo4j/driver/internal/async/pool/ConnectionPoolImpl.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/async/pool/NettyChannelPool.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a routing driver, it is possible that a thread will try to acquire a connection from a pool which might have been closed by another thread.
This happens when thread A obtains a server S to establish a connection. While thread B triggers updating routing table and removes server S from the routing table and connection pool. Then when thread A process to acquire a connection with server S, then we will end up with this pool was closed error.
This race condition cannot be avoided due to the nature of multi-threading. However when it happens, we can catch the error and treat it as a normal IO Error.