Skip to content

Include bookmarks in the ROUTE message. #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

Include bookmarks in the ROUTE message. #861

merged 2 commits into from
Mar 31, 2021

Conversation

gjmwoods
Copy link
Contributor

@gjmwoods gjmwoods commented Mar 30, 2021 •
edited
Loading

Adding bookmarks to ROUTE message

The new format is: ROUTE {routingContext} [listOfBookmarks] dbname
where (in order of occurrence):

  • routingContext provided by the driver.
  • A list of bookmarks. If none are provided then an empty list should be supplied.
  • the dbname of the database for which a new routing table is being requested. This is a string value and can be replaced with null to return the default database's routing table.

@injectives injectives self-requested a review March 31, 2021 10:38
injectives
injectives approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@injectives injectives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjmwoods gjmwoods merged commit b2237b8 into neo4j:4.3 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@injectives injectives injectives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmwoods @injectives