Added value conversion for char[] and short[] #964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Thank you for opening the pull request. 👍 We are currently working on 4.3 branch and backporting changes to 4.2 and 4.1. 1.6 branch is no longer updated. Given that the motivation came from the |
|
The problem actually came up with 4.2 and still exists in 4.3. Shall I update this (or probably better create a new PR) for 4.3? I used 1.6 as target because it is still mentioned as active in https://github.com/neo4j/neo4j-java-driver#java-runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of jQAssistant reported a problem when using a dedicated Neo4j instance (jqassistant-archive/jqa-core-framework#60).
The mapping framework behind jQAssistant (XO) sets properties of a node/relation using
Value.parameterswhere the value is a Map of properties. In the described case one of the properties is of typechar[]but testing revealed thatshort[]is not covered as well.Creating the pull request against 1.6, the version used by jQAssistant actually is 4.3.