Skip to content

Add example for passing bookmarks #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2017

Conversation

ali-ince
Copy link
Contributor

@ali-ince ali-ince commented Dec 4, 2017

No description provided.

@ali-ince ali-ince requested a review from lutovich December 4, 2017 13:39
Copy link
Contributor

@lutovich lutovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ali-ince change looks good to me, but test failed on CI.

}

// To collect the session bookmarks
let savedBookmarks = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe const

// Create the first person and employment relationship.
const session1 = driver.session(neo4j.WRITE);
const first = session1.writeTransaction(tx => addCompany(tx, 'Wayne Enterprises')).then(
ignore => session1.writeTransaction(tx => addPerson(tx, 'Alice'))).then(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() instead of ignore will probably look better

@ali-ince ali-ince merged commit 9040f4e into neo4j:1.5 Dec 14, 2017
@ali-ince ali-ince deleted the 1.5-add-passing-bookmark-example branch December 14, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants