Skip to content

Spelling #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Neo4j Driver 1.6 for Javascript
# Neo4j Driver 1.6 for JavaScript


A database driver for Neo4j 3.0.0+.
Expand Down Expand Up @@ -265,7 +265,7 @@ While there is no need to grab admin right if you are running tests against an e

## A note on numbers and the Integer type
The Neo4j type system includes 64-bit integer values.
However, Javascript can only safely represent integers between `-(2`<sup>`53`</sup>` - 1)` and `(2`<sup>`53`</sup>` - 1)`.
However, JavaScript can only safely represent integers between `-(2`<sup>`53`</sup>` - 1)` and `(2`<sup>`53`</sup>` - 1)`.
In order to support the full Neo4j type system, the driver will not automatically convert to javascript integers.
Any time the driver receives an integer value from Neo4j, it will be represented with an internal integer type by the driver.

Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Documentation for Neo4j Bolt Driver for Javascript
# Documentation for Neo4j Bolt Driver for JavaScript
The docs are generated with [esdoc](https://github.com/esdoc/esdoc), which is added
as a devDependency to this project.

Expand Down
2 changes: 1 addition & 1 deletion esdoc.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"enable": true
},
"brand": {
"title": "Neo4j Bolt Driver 1.6 for Javascript",
"title": "Neo4j Bolt Driver 1.6 for JavaScript",
"repository": "https://github.com/neo4j/neo4j-javascript-driver"
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/v1/integer.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ class Integer {

// The internal representation of an Integer is the two given signed, 32-bit values.
// We use 32-bit pieces because these are the size of integers on which
// Javascript performs bit-operations. For operations like addition and
// JavaScript performs bit-operations. For operations like addition and
// multiplication, we split each number into 16 bit pieces, which can easily be
// multiplied within Javascript's floating-point representation without overflow
// multiplied within JavaScript's floating-point representation without overflow
// or change in sign.
//
// In the algorithms below, we frequently reduce the negative case to the
Expand Down
4 changes: 2 additions & 2 deletions src/v1/internal/buf.js
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,14 @@ class BaseBuffer
}

/**
* Get remaning
* Get remaining
*/
remaining () {
return this.length - this.position;
}

/**
* Has remaning
* Has remaining
*/
hasRemaining () {
return this.remaining() > 0;
Expand Down
2 changes: 1 addition & 1 deletion src/v1/internal/chunking.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class Dechunker {
// no-op
}

/** Called when a complete chunk header has been recieved */
/** Called when a complete chunk header has been received */
_onHeader(header) {
if (header == 0) {
// Message boundary
Expand Down
4 changes: 2 additions & 2 deletions src/v1/internal/connector.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ let NO_OP_OBSERVER = {
};

/**
* A connection manages sending and recieving messages over a channel. A
* A connection manages sending and receiving messages over a channel. A
* connector is very closely tied to the Bolt protocol, it implements the
* same message structure with very little frills. This means Connectors are
* naturally tied to a specific version of the protocol, and we expect
Expand All @@ -103,7 +103,7 @@ class Connection {
constructor(channel, url, disableLosslessIntegers = false) {
/**
* An ordered queue of observers, each exchange response (zero or more
* RECORD messages followed by a SUCCESS message) we recieve will be routed
* RECORD messages followed by a SUCCESS message) we receive will be routed
* to the next pending observer.
*/
this.url = url;
Expand Down
2 changes: 1 addition & 1 deletion src/v1/internal/least-connected-load-balancing-strategy.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default class LeastConnectedLoadBalancingStrategy extends LoadBalancingSt
return null;
}

// choose start index for iteration in round-rodin fashion
// choose start index for iteration in round-robin fashion
const startIndex = roundRobinIndex.next(length);
let index = startIndex;

Expand Down
4 changes: 2 additions & 2 deletions src/v1/result-summary.js
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,14 @@ class StatementStatistics {
}

/**
* @return {Number} - Number of contraints added.
* @return {Number} - Number of constraints added.
*/
constraintsAdded() {
return this._stats.constraintsAdded;
}

/**
* @return {Number} - Number of contraints removed.
* @return {Number} - Number of constraints removed.
*/
constraintsRemoved() {
return this._stats.constraintsRemoved;
Expand Down
2 changes: 1 addition & 1 deletion test/resources/neo4j-wrapper.conf
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ dbms.jvm.additional=-XX:+AlwaysPreTouch

# Trust that non-static final fields are really final.
# This allows more optimisations and improves overall performance.
# NOTE: Disable this if you use embedded mode, or have extensions or depencies that may use reflection or serialization
# NOTE: Disable this if you use embedded mode, or have extensions or dependencies that may use reflection or serialization
# to change the value of final fields!
dbms.jvm.additional=-XX:+UnlockExperimentalVMOptions
dbms.jvm.additional=-XX:+TrustFinalNonStaticFields
Expand Down
2 changes: 1 addition & 1 deletion test/v1/driver.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('driver', () => {

it('should handle connection errors', done => {
// Given
driver = neo4j.driver("bolt://localhoste", sharedNeo4j.authToken);
driver = neo4j.driver("bolt://local-host", sharedNeo4j.authToken);

// Expect
driver.onError = error => {
Expand Down
6 changes: 3 additions & 3 deletions test/v1/routing.driver.boltkit.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -972,11 +972,11 @@ describe('routing driver with stub server', () => {
});

it('should throw protocol error when multiple records', done => {
testForProtocolError('./test/resources/boltstub/unparseable_ttl_get_servers.script', done);
testForProtocolError('./test/resources/boltstub/unparsable_ttl_get_servers.script', done);
});

it('should throw protocol error on unparsable record', done => {
testForProtocolError('./test/resources/boltstub/unparseable_servers_get_servers.script', done);
testForProtocolError('./test/resources/boltstub/unparsable_servers_get_servers.script', done);
});

it('should throw protocol error when no routers', done => {
Expand Down Expand Up @@ -1100,7 +1100,7 @@ describe('routing driver with stub server', () => {
});
});

it('should send initial bookmark wihtout access mode', done => {
it('should send initial bookmark without access mode', done => {
testWriteSessionWithAccessModeAndBookmark(null, 'neo4j:bookmark:v1:tx42', done);
});

Expand Down
2 changes: 1 addition & 1 deletion test/v1/tck/steps/authsteps.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports = function () {
var expectedCode = 'Neo.ClientError.Security.Unauthorized';

if (message.indexOf(expectedStartOfMessage) != 0) {
throw new Error("Wrong error messsage. Expected: '" + expectedStartOfMessage + "'. Got: '" + message + "'");
throw new Error("Wrong error message. Expected: '" + expectedStartOfMessage + "'. Got: '" + message + "'");
}

if (code.indexOf(expectedCode) != 0) {
Expand Down
2 changes: 1 addition & 1 deletion test/v1/tck/steps/erroreportingsteps.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module.exports = function () {
this.Then(/^it throws a `ClientException`$/, function (table) {
var expected = table.rows()[0][0];
if (!this.error) {
throw new Error("Exepcted an error but got none.")
throw new Error("Expected an error but got none.")
}
if (this.error.message.indexOf(expected) != 0) {
if (!(expected == "Unsupported URI scheme:" || expected == "Unable to connect to" ))
Expand Down
2 changes: 1 addition & 1 deletion test/v1/tck/steps/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ function printable(array) {
function getType(val) {
var labels = getLabels(val);
if (labels.length > 1) {
throw new Error("Shuld be single type. Found many: " + labels)
throw new Error("Should be single type. Found many: " + labels)
}
if (labels.length === 0) {
return [];
Expand Down