Include database connection ID in log messages #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database assigns IDs to all incoming connections and can send them back to the client in Bolt V3. IDs are sent in SUCCESS response for HELLO message. Clients can use those IDs for logging to for better connection traceability. The same ID is returned in the output of `dbms.listConnections` procedure. This commit makes driver extract connection ID form the SUCCESS response and include it in logged messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database assigns IDs to all incoming connections and can send them back to the client in Bolt V3. IDs are sent in SUCCESS response for HELLO message. Clients can use those IDs for logging to for better connection traceability. The same ID is returned in the output of
dbms.listConnectionsprocedure.This PR makes driver extract connection ID form the SUCCESS response and include it in logged messages.