Remove tck #438
Merged
Remove tck #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
reviewed
Jan 10, 2019
test/v1/summary.test.js
Outdated
| var profile = summary.profile; | ||
| var plan = summary.plan; | ||
|
|
||
| verifyPlansAreEqual(profile, plan); |
There was a problem hiding this comment.
Can isEqual from lodash be used instead of this function?
I.e. expect(_.isEqual(profile, plan)).toBeTruthy()
There was a problem hiding this comment.
No, my bad, I am actually compare profile and plan. The profile has two extra fields, so the isEqual will not work. Change the method name to verifyProfileAndPlanEqual instead.
test/v1/summary.test.js
Outdated
| it('should get result summary', done => { | ||
| // When & Then | ||
| session.run("CREATE (p:Person { Name: 'Test'})").then(result => { | ||
| var summary = result.summary; |
There was a problem hiding this comment.
Imho it is better to always use let or const instead of var because they have a narrower scope.
Removed cucumber from dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing tck.
Thinking of merging to 2.0.