Skip to content

4.1 gulp set version fix #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020
Merged

4.1 gulp set version fix #598

merged 2 commits into from
Jul 20, 2020

Conversation

martin-neotech
Copy link
Contributor

No description provided.

the --version and -v is gulp specific arguments and cant be used for
task arguments.

changed the argument to --x

old:

gulp set --version 4.0.0

new:

gulp set --x 4.0.0
script that updates 'src/version.js' and package.json'

VERSION=$VERSION npm run versionRelease
@martin-neotech martin-neotech merged commit 7eb9815 into neo4j:4.1 Jul 20, 2020
martin-neotech added a commit that referenced this pull request Jul 21, 2020
* fixed gulp set --version

the --version and -v is gulp specific arguments and cant be used for
task arguments.

changed the argument to --x

old:

gulp set --version 4.0.0

new:

gulp set --x 4.0.0

* fixed the npm run versionRelease command to use new gulp set command

script that updates 'src/version.js' and package.json'

VERSION=$VERSION npm run versionRelease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant