Deprecate .commit(), .rollback() or .close() managed transactions
#890
+381
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: neo4j-drivers/testkit#415 |
bigmontz
force-pushed
the
5.0-tx-lifetime
branch
from
a8a5ad8 to
b7a98c4
Compare
bigmontz
changed the title
.commit(), .rollback() or .close() managed transactions.commit(), .rollback() or .close() managed transactions
Not anymore |
bigmontz
force-pushed
the
5.0-tx-lifetime
branch
from
82fe2fd to
d281114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing self-manage managed transactions could causing unexpected behaviours in the user code depends on how the different possible code paths in the transaction work.