Skip to content

Add support to pickling DateTime #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Add support to pickling DateTime #1002

merged 5 commits into from
Dec 20, 2023

Conversation

Tanguy-Boisset
Copy link
Contributor

@Tanguy-Boisset Tanguy-Boisset commented Dec 7, 2023

Fixes #1001

@robsdedude
Copy link
Member

robsdedude commented Dec 8, 2023

Thank you very much for taking the time to craft this PR.

However, before I can review the code, please sign the CLA (Contributor License Agreement).

@Tanguy-Boisset
Copy link
Contributor Author

Hi, I have sent the email and signed the CLA yesterday. I'm unsure whether I have to do something else or not.

@robsdedude
Copy link
Member

robsdedude commented Dec 8, 2023

Nope. For now, nothing else is required from your side :) Sorry, I didn't see your CLA mail before. I'll let you know once I'm done with the review.

@robsdedude robsdedude self-requested a review December 14, 2023 13:36
Adding unit tests
Fixing (deep)copy support not considering dynamic attributes
@robsdedude robsdedude merged commit 018a49f into neo4j:5.0 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when serializing DateTime object with pickle
3 participants