Set TCP_NODELAY #1122
Merged
Set TCP_NODELAY #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyHeap-NeoTech
approved these changes
Nov 22, 2024
| @@ -548,6 +551,12 @@ def _connect(cls, resolved_address, timeout, keep_alive): | |||
| s = socket(AF_INET6) | |||
| else: | |||
| raise ValueError(f"Unsupported address {resolved_address!r}") | |||
| try: | |||
There was a problem hiding this comment.
If the exception is raised does that surface to the user or get logged and the driver continues to operate using Nagels algorithm?
There was a problem hiding this comment.
The intention is that we do this on a best-effort basis. If the socket option is not available (i.e., exception is being raised), we'll just ignore it and do what we were doing before this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yields a small performance improvement by disabling Nagle's algorithm on the TCP sockets.
The change only affects the synchronous driver as most async runtime implementations already set this socket option for us.