[ADR-001] bookmark manager #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
changed the title
robsdedude
force-pushed
the
bookmark-manager
branch
from
20326d9 to
b2b6f42
Compare
* respect database reported in summary * fix lock usage * other small fixes
Implement ADR adjustments to bookmark manager neo-technology/drivers-adr#30
`bookmark_consumer` -> `bookmarks_consumer` `bookmark_supplier` -> `bookmarks_supplier` neo-technology/drivers-adr#31
fbiville
reviewed
Aug 19, 2022
bigmontz
requested changes
Aug 19, 2022
Signed-off-by: Rouven Bauer <[email protected]>
The change was meant to get rid of a deprecation warning. It'll be moved into it's own PR.
* Avoid calling the BMM implementation that's shipped with the driver "default bookmark manger". This could lead users to believe it's enabled by default. * little oversights Signed-off-by: Rouven Bauer <[email protected]>
robsdedude
commented
Aug 22, 2022
* Adjust BMM interface: bookmark types are now `Collection`s instead of `Iterable`s. This allows for slightly more efficient BMM implementations without creating significant friction in the usage of BMMs. * Docs typo. Signed-off-by: Rouven Bauer <[email protected]>
Discovered by Antonio
bigmontz
approved these changes
Aug 23, 2022
fbiville
approved these changes
Aug 30, 2022
Co-authored-by: Florent Biville <[email protected]>
|
Waiting for neo4j-drivers/testkit#509 to be merged. Then re-run CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: