Skip to content

fix(highlights): link to more relevant groups #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

justinmk
Copy link
Member

@justinmk justinmk commented Oct 9, 2022

  • @text.literal seems appropriate for a codespan/codeblock.
  • optionlink and taglink should use the same highlight.

- `@text.literal` seems appropriate for a codespan/codeblock.
- `optionlink` and `taglink` should use the same highlight.
@clason
Copy link
Member

clason commented Oct 9, 2022

could add uri (link to @text.uri)

@justinmk
Copy link
Member Author

justinmk commented Oct 9, 2022

is there anything for codeblock ? or is it also just @text.literal ?

@clason
Copy link
Member

clason commented Oct 9, 2022

Ideally, we'll use an injection for that, anyway ;) In the meantime, we could also use a custom capture (@text.example or @text.codeblock)?

Otherwise, @text.literal sounds to me like the best option as well.

@justinmk justinmk merged commit bf6a269 into neovim:master Oct 13, 2022
@justinmk justinmk deleted the hl branch October 13, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants