Skip to content

Fix sample_create_vocab function to use String keys and i32 values in the vocabulary HashMap #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix sample_create_vocab function to use String keys and i32 values in the vocabulary HashMap #349

merged 1 commit into from
Mar 5, 2025

Conversation

giodefa96
Copy link
Contributor

  • From listings 2.2 in Chapter 2, the return value of the HashMap is reversed. So I modified the return value of the function.

nerdai
nerdai approved these changes Mar 5, 2025
View reviewed changes
Copy link
Owner

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @giodefa96!

@nerdai nerdai merged commit dcd41b5 into nerdai:main Mar 5, 2025
3 checks passed
@nerdai nerdai mentioned this pull request Mar 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdai nerdai nerdai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giodefa96 @nerdai