[client] Fix exit node deselection

[lixmal]

Describe your changes

When deselecting a single exit node in the menu the exit node was deselected but the checkbox wasn't unchecked properly. This fixes it

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[Copilot]

Pull Request Overview

This PR fixes the exit node deselection behavior in the client systray menu by properly updating the checkbox state when a single exit node is deselected.

• Updated the toggling logic to use a deselect flag and update node states accordingly
• Removed the redundant parameter from the deselectOtherExitNodes function and added logging for clarity

Comments suppressed due to low confidence (2)

client/ui/network.go:460

• [nitpick] Consider renaming 'deselectAll' to a more descriptive name (e.g., 'shouldDeselect') to better reflect its purpose.

deselectAll := item.Checked() && len(ids) == 0

client/ui/network.go:490

• The updated deselectOtherExitNodes function now unchecks all exit node menu items without skipping the current one. Please verify that this change is intentional and that selectNewExitNode reliably re-checks the active item when needed.

func (s *serviceClient) deselectOtherExitNodes(conn proto.DaemonServiceClient, ids []string) error {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud