Move static check when running on foreground #3742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves the static platform and system information update to occur only when running in foreground (i.e. when logFile is set to "console"), ensuring that the update is skipped for service mode.
- Relocated system.UpdateStaticInfo() inside the foreground login branch
- Adjusted comment placement to clarify the update's context
Comments suppressed due to low confidence (1)
client/cmd/login.go:59
- Moving system.UpdateStaticInfo() inside the 'if logFile == "console"' block means that static platform and system information will not be updated for non-foreground logins. Please confirm that this change is intentional and won't affect service mode functionality.
system.UpdateStaticInfo()
|
lixmal
approved these changes
Apr 25, 2025
|
merging since the docker test fix is not there yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist