[misc] Exclude client benchmarks from CI #3752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow to exclude client benchmarks from running during CI.
- It modifies grep commands in the test steps to filter out benchmark directories including /management, /signal, /relay, and /client/ui.
- It narrows the benchmark execution to the ./management directory, effectively omitting client benchmarks.
Comments suppressed due to low confidence (2)
.github/workflows/golang-test-linux.yml:418
- [nitpick] The benchmark execution is now limited to the ./management directory, which aligns with the PR purpose. Please confirm that no other essential benchmark directories are unintentionally omitted.
-timeout 20m ./management/...
.github/workflows/golang-test-linux.yml:147
- Using multiple patterns without the -e flag may cause grep to misinterpret subsequent patterns as file names. Consider reverting to the original syntax with separate -e flags for each exclusion pattern.
run: CGO_ENABLED=1 GOARCH=${{ matrix.arch }} CI=true go test -tags devcert -exec 'sudo' -timeout 10m -p 1 $(go list ./... | grep -v /management /signal /relay)
lixmal
force-pushed
the
remove-client-bench
branch
2 times, most recently
from
0841839 to
996df53
Compare
lixmal
force-pushed
the
remove-client-bench
branch
from
996df53 to
70ad946
Compare
|
mlsmaycon
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist