Skip to content

[management] limit peers based on module read permission #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

pnmcosta
Copy link
Contributor

@pnmcosta pnmcosta commented Apr 29, 2025

Describe your changes

This PR shifts the logic to filter account peers by user ownership to only when a user does not have the module read permission, thus not being necessary to explicitly check for the user role when filtering.

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pnmcosta pnmcosta changed the title Fix/auditor view all peers [management] limit peers based on read permission Apr 29, 2025
@pnmcosta pnmcosta changed the title [management] limit peers based on read permission [management] limit peers based on module read permission Apr 29, 2025
@pnmcosta pnmcosta marked this pull request as ready for review April 29, 2025 18:44
@pnmcosta pnmcosta requested a review from pascal-fischer April 30, 2025 07:38
Copy link

@crn4 crn4 self-requested a review April 30, 2025 14:48
Copy link
Contributor

@crn4 crn4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnmcosta pnmcosta merged commit b5419ef into main Apr 30, 2025
32 of 35 checks passed
@pnmcosta pnmcosta deleted the fix/auditor-view-all-peers branch April 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants