[client] Revert mgm client error handling #3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the mgm client error handling logic for the gRPC client.
- Removed explicit connection closure and state checking after streaming.
- Simplified the error handling by directly returning the error from handleStream.
Comments suppressed due to low confidence (1)
management/client/grpc.go:131
- Reverting the previous error handling removed the explicit connection closure step. Please confirm that the connection resource is properly closed elsewhere to prevent potential resource leaks.
return c.handleStream(ctx, *serverPubKey, sysInfo, msgHandler)
lixmal
approved these changes
Apr 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist