[client] Add debug upload option to netbird ui #3768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the NetBird UI by adding a debug upload option. Key changes include introducing a default bundle URL in the upload-server, implementing a new debug window with options to anonymize, include system information, and control debug bundle upload, and updating the CLI flags and service client initialization to incorporate the debug UI.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| upload-server/types/upload.go | Added a new constant (DefaultBundleURL) to define the debug upload URL. |
| client/ui/debug.go | Introduced the new debug window UI with options for file upload and detailed dialogs for success/failure feedback. |
| client/ui/client_ui.go | Updated flag parsing and service client creation to include the new debug flag and proper UI routing. |
| client/cmd/root.go | Modified the CLI flag default for the debug upload URL to use the new DefaultBundleURL. |
Comments suppressed due to low confidence (1)
client/ui/debug.go:90
- [nitpick] For consistency with similar variable names used elsewhere (e.g., uploadURL), consider renaming 'uploadUrl' to 'uploadURL'.
var uploadUrl string
|
mlsmaycon
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
with upload:
without:
Issue ticket number and link
Stack
Checklist