[client] Add debug for duration option to netbird ui #3772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the NetBird UI by adding debug support for duration options and refactoring window handling for network-related views while integrating logging improvements.
- Renames the network window variable from wRoutes to wNetworks and updates corresponding function calls.
- Adds log file support by updating the initLogFile API and propagating the log file path to relevant service client functions.
- Refactors error logging and context handling across UI and command modules.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| client/ui/network.go | Renames window variable to improve clarity and updates UI callbacks. |
| client/ui/client_ui.go | Introduces log file handling and updates service client initialization. |
| client/server/debug.go | Enhances debug bundle upload logging. |
| client/cmd/debug.go | Removes network map persistence disablement during debug bundling. |
|
mlsmaycon
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist