Skip to content

[management] removal of foreign key constraint enforcement on sqlite #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 15:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the foreign key constraint enforcement for SQLite in the SQL store configuration to avoid errors stemming from unsupported settings in SQLite.

  • The execution of the PRAGMA statement to enforce foreign keys in SQLite has been removed.
  • The default maximum open connections for SQLite is maintained as 1.
Comments suppressed due to low confidence (1)

management/server/store/sql_store.go:82

  • Consider adding a comment to explain why foreign key enforcement is removed for SQLite, noting that this behavior is intentional and may differ from other database engines to prevent unsupported settings from causing errors.
_, err = sql.Exec("PRAGMA foreign_keys = ON")

Copy link

sonarqubecloud bot commented May 5, 2025

@pascal-fischer pascal-fischer merged commit 25faf92 into main May 5, 2025
34 of 35 checks passed
@pascal-fischer pascal-fischer deleted the fix/remove-enforcing-foreign-keys branch May 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants