Skip to content

[client] Return with the correct copied length #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

[client] Return with the correct copied length #3804

merged 1 commit into from
May 9, 2025

Conversation

pappz
Copy link
Contributor

@pappz pappz commented May 9, 2025 •
edited
Loading

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 09:22
Copilot
Copilot AI reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A bug fix PR to correct the returned copied length in the ReadFrom function.

  • Updated the function signature to remove named return parameters.
  • Changed the returned length from a constant value to the actual number of bytes copied.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pappz pappz merged commit cad2fe1 into main May 9, 2025
32 checks passed
@pappz pappz deleted the fix/read-len branch May 9, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lixmal lixmal lixmal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pappz @lixmal