[client, android] Do not propagate empty routes #3805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where domain routes were being propagated to the Android client by filtering out invalid network routes.
- Added a filter in the route processing to exclude routes with invalid network prefixes before handing them off to Android.
| @@ -32,6 +32,10 @@ func (n *Notifier) SetListener(listener listener.NetworkChangeListener) { | |||
| func (n *Notifier) SetInitialClientRoutes(clientRoutes []*route.Route) { | |||
| nets := make([]string, 0) | |||
| for _, r := range clientRoutes { | |||
| // filter out domain routes | |||
| if !r.Network.IsValid() { | |||
There was a problem hiding this comment.
[nitpick] Consider adding a debug log statement when filtering out an invalid route. This would help in troubleshooting by providing visibility into which routes are being filtered out at runtime.
Suggested change
| if !r.Network.IsValid() { | |
| if !r.Network.IsValid() { | |
| log.Printf("Filtering out invalid route: %v", r.Network) |
Copilot uses AI. Check for mistakes.
lixmal
reviewed
May 9, 2025
|
lixmal
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If we get domain routes the Network prefix variable in route structure will be invalid (engine.go:1057). When we handower to Android the routes, we must to filter out the domain routes. If we do not do it the Android code will get "invalid prefix" string as a route.
Issue ticket number and link
Stack
Checklist