[client, android] Fix/notifier threading

[pappz]

Describe your changes

• Fix potential deadlocks
• When adding a listener, immediately notify with the last known IP and fqdn.

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[Copilot]

Pull Request Overview

This PR removes the Android-specific stub router, unifies server routing on all platforms, and refactors the peer notifier to safely publish the last known address, FQDN, and peer count to new listeners while filtering out dynamic/domain routes in the routemanager notifier.

• Drop server_android.go and lift !android build tag so the same server logic runs on Android
• In notifier.go, filter out dynamic/domain routes when setting initial client routes
• In peer/notifier.go, add last-known address/FQDN state, restructure locking, and immediately notify new listeners without deadlocking

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
client/internal/routemanager/server_android.go	Removed Android stub that returned “not supported” error
client/internal/routemanager/server.go	Removed //go:build !android so server logic applies on Android
client/internal/routemanager/notifier/notifier.go	Added filter to exclude dynamic/domain routes from initial client routes
client/internal/peer/notifier.go	Tracked last address/FQDN, refactored locks, and extracted notify logic

Comments suppressed due to low confidence (2)

client/internal/peer/notifier.go:34

• [nitpick] Variable name address is ambiguous. Rename to ipAddress for clarity and to distinguish from FQDN.

address := n.lastIPAddress

client/internal/routemanager/notifier/notifier.go:36

• Filtering out dynamic/domain routes adds new behavior. Add unit tests covering both dynamic and static routes to verify they render in the initial list correctly.

if r.IsDynamic() {

[Copilot]

State-change callbacks are now dispatched synchronously via notifyListener, which may block the caller or violate threading expectations on the Java side. Consider wrapping these calls in a goroutine, similar to OnPeersListChanged.

Suggested change

	notifyListener(listener, lastNotification)
	// run on go routine to avoid on Java layer to call go functions on same thread
	// run on go routine to avoid on Java layer to call go functions on same thread
	go notifyListener(listener, lastNotification)

[Copilot]

[nitpick] The manual lock/unlock patterns repeat across methods, making the code verbose. Consider extracting a helper or using scoped defer blocks to simplify lock management.

Suggested change

	n.lastNumberOfPeers = numOfPeers
	n.serverStateLock.Unlock()
	defer n.serverStateLock.Unlock()
	n.lastNumberOfPeers = numOfPeers

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud