[signal] adjust log levels #3813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts log levels in the signal service to reduce log verbosity and better align with production requirements. The changes include reordering the dispatcher import for improved clarity, switching log levels in the server from Debugf to Tracef, and downgrading warning messages in the peer package from Warnf to Debugf.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| signal/server/signal.go | Reordered dispatcher import; log level changed from Debugf to Tracef. |
| signal/peer/peer.go | Log level changes: duplicate registration and removal logs updated from Warnf to Debugf. |
Comments suppressed due to low confidence (3)
signal/peer/peer.go:82
- Ensure that lowering the log level from Warnf to Debugf for duplicate peer registration does not hide critical warnings during runtime.
log.Debugf("peer [%s] is already registered [new streamID %d, previous StreamID %d]. Will override stream.", peer.Id, peer.StreamID, pp.StreamID)
signal/peer/peer.go:107
- Confirm that reducing the log severity for ignoring newer stream removal is intentional and won't mask potential issues.
log.Debugf("attempted to remove newer registered stream of a peer [%s] [newer streamID %d, previous StreamID %d]. Ignoring.", peer.Id, pp.StreamID, peer.StreamID)
signal/server/signal.go:73
- Verify that adjusting the log level from Debugf to Tracef meets the intended verbosity requirements. If needed, document the rationale for this change.
log.Tracef("received a new message to send from peer [%s] to peer [%s]", msg.Key, msg.RemoteKey)
|
crn4
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist