Skip to content

[signal] adjust signal log levels 2 #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Copilot Copilot AI review requested due to automatic review settings May 12, 2025 20:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the log levels for signal operations to reduce verbosity in production logs.

  • Changed the log level in message forwarding from Warn to Trace
  • Changed the log level in peer registration from Debug to Trace

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
signal/server/signal.go Downgraded error log level when forwarding messages
signal/peer/peer.go Downgraded log level when a peer is already registered
Comments suppressed due to low confidence (2)

signal/peer/peer.go:82

  • Lowering the log level from Debug to Trace for duplicate peer registration may reduce the visibility of potential conflicts; please ensure that this change aligns with the overall logging strategy for peer management.
log.Tracef("peer [%s] is already registered [new streamID %d, previous StreamID %d]. Will override stream.", peer.Id, peer.StreamID, pp.StreamID)

signal/server/signal.go:172

  • Changing the error log level from Warn to Trace may hide important error details in production; consider verifying that less severe logging is acceptable for error reporting in this context.
log.Tracef("error while forwarding message from peer [%s] to peer [%s] %v", msg.Key, msg.RemoteKey, err)

Copy link

@pascal-fischer pascal-fischer merged commit efb0edf into main May 12, 2025
32 checks passed
@pascal-fischer pascal-fischer deleted the chore/signal-log-level branch May 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants