[client] Add FreeBSD desktop client support to OAuth flow

[hakansa]

Describe your changes

[client] Add FreeBSD desktop client support to OAuth flow

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[Copilot]

Pull Request Overview

This PR adds FreeBSD desktop client support to the OAuth flow by introducing a new boolean parameter and relevant checks across several client components.

• New parameter and environment check for FreeBSD desktop clients in OAuth flow initialization
• Updates to proto definitions and client-side logic for iOS, Android, and command-line login support

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
client/server/server.go	Updated OAuth flow initialization to include FreeBSD desktop client support
client/proto/daemon.proto	Added isFreeBSDDesktopClient field to the LoginRequest message
client/ios/NetBirdSDK/client.go	Adjusted OAuth flow call to include FreeBSD desktop support parameter
client/internal/auth/oauth.go	Modified NewOAuthFlow to handle FreeBSD environment checking
client/cmd/login.go	Added function isFreeBSDRunningDesktop and updated login commands to support FreeBSD
client/android/login.go	Included FreeBSD parameter in OAuth flow initialization for consistency

[avg-I]

I am curious if the additional parameter for FreeBSD desktop is really needed.
It seems that desktop detection and handling is totally identical between Linux and FreeBSD.
So, could they just use the same "is(Unix)Desktop" flag?

[hakansa]

I am curious if the additional parameter for FreeBSD desktop is really needed. It seems that desktop detection and handling is totally identical between Linux and FreeBSD. So, could they just use the same "is(Unix)Desktop" flag?

@avg-I what about Wayland? Haven't used it before. So I'm not sure if it's being used widely.

[avg-I]

@avg-I what about Wayland? Haven't used it before. So I'm not sure if it's being used widely.

@hakansa I think that there should not be any difference between Linux and FreeBSD either.
I.e., the DESKTOP / XDG checks should be sufficient for most desktop environments.
If you want to double-check based on DISPLAY / WAYLAND_DISPLAY (e.g., for people running some minimalist graphic setup), then I do not see a reason to not do that on Linux as well.

[hakansa]

@avg-I well let's use the same parameter for now, we might need to seperate them for other OS'es in future, no need for now.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud