[client] Fix legacy routes when connecting to mgmt servers older than v0.30.0 #3854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of legacy routes when a client connects to management servers older than v0.30.0 by centralizing the legacy flag logic in the engine and removing duplicate code in the ACL manager.
- Add legacy management flag logic in Engine.updateNetworkMap before applying routes
- Remove redundant legacy flag handling from DefaultManager.ApplyFiltering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/internal/engine.go | Added check for legacy management servers and set firewall flag before routes |
| client/internal/acl/manager.go | Removed duplicate legacy flag logic from ACL manager |
Comments suppressed due to low confidence (1)
client/internal/engine.go:965
- Consider adding unit tests to verify that SetLegacyManagement is invoked when connecting to management servers older than v0.30.0 (i.e., when RoutesFirewallRules is empty but RoutesFirewallRulesIsEmpty is false).
isLegacy := len(networkMap.RoutesFirewallRules) == 0 && !networkMap.RoutesFirewallRulesIsEmpty
|
hakansa
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
v0.40.0 switched the order of applying ACLs and routes, making setting up legacy management too late. So, we moved it to an earlier place in the network map update.
Issue ticket number and link
Fixes #3841
Stack
Checklist